Skip to content

Support setting cpu_request in cluster replica sizes#35196

Merged
alex-hunt-materialize merged 2 commits intoMaterializeInc:mainfrom
alex-hunt-materialize:cpu_request_support
Mar 4, 2026
Merged

Support setting cpu_request in cluster replica sizes#35196
alex-hunt-materialize merged 2 commits intoMaterializeInc:mainfrom
alex-hunt-materialize:cpu_request_support

Conversation

@alex-hunt-materialize
Copy link
Contributor

@alex-hunt-materialize alex-hunt-materialize commented Feb 24, 2026

Supports setting cpu_request independently of cpu_limit in cluster replica sizes.

Motivation

Resolves https://github.com/MaterializeInc/database-issues/issues/10100

More context:
https://materializeinc.slack.com/archives/C07PN7KSB0T/p1770215227882419
https://materializeinc.slack.com/archives/C0854GU86HL/p1771932457688129

Description

  • Adds support for setting cpu_request independently of cpu_limit in ReplicaAllocation.

Verification

Orchestratord nightly tests should exercise this.

@github-actions
Copy link

github-actions bot commented Feb 24, 2026

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@alex-hunt-materialize alex-hunt-materialize force-pushed the cpu_request_support branch 17 times, most recently from 5afeb42 to 1e7420c Compare March 2, 2026 16:45
@alex-hunt-materialize alex-hunt-materialize marked this pull request as ready for review March 3, 2026 12:04
@alex-hunt-materialize alex-hunt-materialize requested review from a team as code owners March 3, 2026 12:04
@alex-hunt-materialize alex-hunt-materialize requested a review from a team as a code owner March 3, 2026 14:28
Copy link
Contributor

@kay-kim kay-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs changes LGTM 😍😍 😍

@alex-hunt-materialize alex-hunt-materialize merged commit b1c657d into MaterializeInc:main Mar 4, 2026
135 checks passed
@alex-hunt-materialize alex-hunt-materialize deleted the cpu_request_support branch March 4, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants