fix(combobox): allow dropdown toggle when clicking prefix or suffix text - #4091
Open
corvinsz wants to merge 1 commit into
Open
fix(combobox): allow dropdown toggle when clicking prefix or suffix text#4091corvinsz wants to merge 1 commit into
corvinsz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4090
Sets
IsHitTestVisible="False"on the internalPrefixTextBlockandSuffixTextBlockso mouse events are handled by the underlyingComboBox.I tested clicking both the Prefix and Suffix in the same test rather than using two separate tests (or making the test data-driven) to avoid the overhead of starting the app multiple times.
@Keboo I'm not 100% sure whether the
Task.Delay(50)is appropriate here, or if this should instead use aWait.For(...)call. There is a test above that uses the same 50ms delay, so I followed that approach.