fix(weather): use stable instanceId to prevent duplicate fetchers#4092
Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom Apr 5, 2026
Merged
fix(weather): use stable instanceId to prevent duplicate fetchers#4092rejas merged 1 commit intoMagicMirrorOrg:developfrom
rejas merged 1 commit intoMagicMirrorOrg:developfrom
Conversation
During the server-side migration (PR MagicMirrorOrg#4032), the `instanceId` was built with `Date.now()`, making it unique per client reload. This was fine in the old browser-based architecture where reloads cleaned up everything automatically. But now the node_helper persists across reloads, so each reconnect created a new `HTTPFetcher` while the old one kept polling — silently multiplying API calls over time. The fix is simple: use `this.identifier` as the `instanceId`, which is already stable and unique per module slot. This is the same approach the Calendar module uses. On the node_helper side, when a provider already exists for the same `instanceId`, we now skip re-creation and just resend `WEATHER_INITIALIZED` so the client picks up where it left off. Fixes https://forum.magicmirror.builders/topic/20199
rejas
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the server-side migration (PR #4032), the
instanceIdwas built withDate.now(), making it unique per client reload. This approach was fine in the old browser-based architecture where reloads cleaned up everything automatically. But now the node_helper persists across reloads, so each reconnect created a newHTTPFetcherwhile the old one kept polling - silently multiplying API calls over time.The fix is simple: use
this.identifieras theinstanceId, which is already stable and unique per module slot. This is the same approach the Calendar module uses.On the node_helper side, when a provider already exists for the same
instanceId, we now skip re-creation and just resendWEATHER_INITIALIZEDso the client picks up where it left off.Fixes https://forum.magicmirror.builders/topic/20199