Skip to content

Clarifications and fixes for light extensions#21

Open
lelievres wants to merge 2 commits into
mainfrom
lights_updates
Open

Clarifications and fixes for light extensions#21
lelievres wants to merge 2 commits into
mainfrom
lights_updates

Conversation

@lelievres
Copy link
Copy Markdown
Collaborator

This pull request addresses issue #20 on MPEG light extension.

@edrthomas
Copy link
Copy Markdown
Contributor

Thanks @lelievres for work. The changes look good but I would suggest we hold on on this PR until we process the input https://git.mpeg.expert/MPEG/Systems/SceneDescription/MPEG-Contributions/-/issues/946.

This contribution proposes the modify again this aspect ...

@edrthomas
Copy link
Copy Markdown
Contributor

@lelievres @ibouazizi I have updated the schema with the spec, please check.

@lelievres
Copy link
Copy Markdown
Collaborator Author

@lelievres @ibouazizi I have updated the schema with the spec, please check.

Thanks @edrthomas for the updates. It looks fine to me.
My proposal is to apply the change to the https://github.com/MPEGGroup/glTF (I can handle that) and to finalize the check through the corresponding pull request (MPEGGroup/glTF#3).

@lelievres
Copy link
Copy Markdown
Collaborator Author

@lelievres @ibouazizi I have updated the schema with the spec, please check.

Thanks @edrthomas for the updates. It looks fine to me. My proposal is to apply the change to the https://github.com/MPEGGroup/glTF (I can handle that) and to finalize the check through the corresponding pull request (MPEGGroup/glTF#3).

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants