Reduce required procs for some landice tests#941
Open
matthewhoffman wants to merge 3 commits intoMPAS-Dev:mainfrom
Open
Reduce required procs for some landice tests#941matthewhoffman wants to merge 3 commits intoMPAS-Dev:mainfrom
matthewhoffman wants to merge 3 commits intoMPAS-Dev:mainfrom
Conversation
For more expensive tests, we want to use more resources when available, but still support them at lower task counts if necessary. The logic has a few requirements over standard ntasks/min_tasks functionality: * Tests with the FO velo solver need a lot more resources than others * For the decomp test, we have to guard against min_tasks leading to the same number of tasks on both runs
Member
Author
TestingPrior to the commit, the landice full_integration suite had 7 test fail due to insufficient processors available when running on my Mac in the container where only 10 procs are available: With this branch, all tests pass: In looking at how the tests were set up, I confirmed that the |
Member
Author
|
@xylar , you don't necessarily need to make an in-depth review of this, but you might look it over and consider if there are any reasons this approach might be a concern. There is no urgency on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts 3 of the landice tests (humboldt, greenland, thwaites) to require a fewer number of processors. This is done in a way that addresses 2 points of complexity:
Checklist
api.rst) has any new or modified class, method and/or functions listedTestingin this PR) any testing that was used to verify the changes