fix: normalize PersistenceLength by n_frames instead of trajectory n_frames - #5456
fix: normalize PersistenceLength by n_frames instead of trajectory n_frames#5456shubhrai23 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes incorrect normalization in PersistenceLength when run(start=..., stop=...) processes only a subset of trajectory frames, ensuring results are normalized by the number of analyzed frames rather than the total trajectory length.
Changes:
- Normalize
results.bond_autocorrelationusingself.n_frames(frames actually processed by the analysis run) instead ofself._trajectory.n_frames(total frames in the trajectory).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Documentation build overview
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5456 +/- ##
========================================
Coverage 93.87% 93.87%
========================================
Files 182 182
Lines 22522 22522
Branches 3206 3206
========================================
Hits 21143 21143
Misses 917 917
Partials 462 462 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BradyAJohnston
left a comment
There was a problem hiding this comment.
We cannot review anything until you have properly used the PR template and properly filled it. Please do note remove the template when opening a PR.
Resolves #5453