fix(wayland): use the current wl_output mode#5150
Open
zacharydenton wants to merge 1 commit into
Open
Conversation
wl_output.mode is emitted for every advertised mode, not just the active one. The current code overwrites viewport.width and viewport.height on every mode event, which can leave Sunshine latched to a supported mode instead of the current mode. When that happens, wlgrab sees every captured frame as a size mismatch and reinitializes endlessly. Track the compositor's current mode explicitly and only fall back to the first advertised mode until a current one is seen. Signed-off-by: Zach Denton <z@chdenton.com>
|
Member
|
Thank you for the PR submission, but I noticed you didn't use our PR template. Please update the PR to use the correct template. You can find it at https://github.com/LizardByte/.github/blob/master/.github/pull_request_template.md?plain=1 |
Author
|
@ReenigneArcher Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
wl_output.modeis emitted for every advertised mode, not just the active one.The current code overwrites
viewport.widthandviewport.heighton every mode event, which can leave Sunshine latched to a supported mode instead of the current mode.When that happens,
wlgrabsees every captured frame as a size mismatch and reinitializes endlessly.This tracks the compositor's current mode explicitly and only falls back to the first advertised mode until a current one is seen.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage