Skip to content

feat: add disambiguation module for sc2#7382

Open
hjpalpha wants to merge 1 commit intomainfrom
sc2-disambig
Open

feat: add disambiguation module for sc2#7382
hjpalpha wants to merge 1 commit intomainfrom
sc2-disambig

Conversation

@hjpalpha
Copy link
Copy Markdown
Collaborator

Summary

used on disambig pages to easily display info for players with the same id

How did you test this change?

dev

@hjpalpha hjpalpha requested review from a team as code owners April 10, 2026 12:55
@hjpalpha hjpalpha added the g: starcraft Starcraft label Apr 10, 2026
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have this on commons IMO :)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm
sure we can move it to commons, maybe as PlayerDisambiguation?
(it is only for players)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

g: starcraft Starcraft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants