Skip to content

feat: add 2 modules used in some cleanup forms on sc2#7365

Open
hjpalpha wants to merge 5 commits intomainfrom
modules-for-sc2-cleanup-forms
Open

feat: add 2 modules used in some cleanup forms on sc2#7365
hjpalpha wants to merge 5 commits intomainfrom
modules-for-sc2-cleanup-forms

Conversation

@hjpalpha
Copy link
Copy Markdown
Collaborator

@hjpalpha hjpalpha commented Apr 8, 2026

Summary

as title says

How did you test this change?

live

@hjpalpha hjpalpha requested review from a team as code owners April 8, 2026 11:29
@hjpalpha hjpalpha added the g: starcraft Starcraft label Apr 8, 2026
Copy link
Copy Markdown
Collaborator

@ElectricalBoy ElectricalBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo using Class.export and changing param for both to args would allow more flexibility

@hjpalpha
Copy link
Copy Markdown
Collaborator Author

hjpalpha commented Apr 8, 2026

imo using Class.export and changing param for both to args would allow more flexibility

  • it is only called from forms which (currently) requires a template that then invokes the module(s) so only usage will likely ever be from that
  • Arguments.getArgs() can eat a normal table without issues, it would just return that table
image

@ElectricalBoy
Copy link
Copy Markdown
Collaborator

Arguments.getArgs() can eat a normal table without issues, it would just return that table

yeah it does, but ---@param frame Frame type annotation will complain regardless
well, if it is called by templates only then I guess it wouldn't be a huge problem anyway

Comment thread lua/wikis/starcraft2/FindMatchesByPlayerDisplayName.lua Outdated
Comment thread lua/wikis/starcraft2/FindMatchesByPlayerDisplayName.lua Outdated
Comment thread lua/wikis/starcraft2/FindPlayersOnTeamFromPlacements.lua Outdated
Comment thread lua/wikis/starcraft2/FindPlayersOnTeamFromPlacements.lua Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

g: starcraft Starcraft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants