Skip to content

feat(infobox): add SeriesTotalPrize#7360

Open
hjpalpha wants to merge 2 commits intomainfrom
SeriesTotalPrize
Open

feat(infobox): add SeriesTotalPrize#7360
hjpalpha wants to merge 2 commits intomainfrom
SeriesTotalPrize

Conversation

@hjpalpha
Copy link
Copy Markdown
Collaborator

@hjpalpha hjpalpha commented Apr 8, 2026

Summary

How did you test this change?

live (just with different module name

after merge

archive/nuke

@hjpalpha hjpalpha requested a review from ElectricalBoy April 8, 2026 10:44
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather SeriesPrizeByTier if i understand correctly? Cause total prize of a series is already part of the commons Infobox/Series.
Perhaps it would also be an option to move this to a dedicated table on the page and not in the infobox?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can do both only total as well as by tier
not opposed to adding it to commons infobox series completely (if a series has only 1 tier it is just 1 value anyways)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was rather suggesting to move it out of the infobox into a dedicated template, which could also use a chart or something

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo that wouldn't make much sense as you would need to manually add the template on series that have events with different tiers while not adding it to series that do not hve several tiers

also series infobox is relatively short, so adding 1-2 additional lines isn't much

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added #7379 as an alternative

hjpalpha added a commit that referenced this pull request Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants