lights.msm8960: add missing libhardware_headers dependency - #3
Open
deepsidhu1313 wants to merge 1 commit into
Open
deepsidhu1313 wants to merge 1 commit into
deepsidhu1313 wants to merge 1 commit into
Conversation
lights.c includes hardware/lights.h, which lives under hardware/libhardware/include_vendor (this is a LOCAL_VENDOR_MODULE) and is exported by the libhardware_headers Soong header-only module (already vendor_available). This Android.mk never declared the dependency, so the include path wasn't reaching the vendor compile. Sibling qcom-caf/msm8960 legacy HAL modules (e.g. display/libmemtrack/Android.mk) already use this exact LOCAL_HEADER_LIBRARIES pattern -- applied it here too. Change-Id: If3415b3686173511433fd70ca3d39c0855a5dde4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while building lineage-21.0 for flo/flox (Nexus 7 2013) via LineageOS-UL.
lights.c includes hardware/lights.h, which lives under hardware/libhardware/include_vendor (this is a LOCAL_VENDOR_MODULE) and is exported by the libhardware_headers Soong header-only module (already vendor_available). This Android.mk never declared the dependency, so the include path wasn't reaching the vendor compile. Sibling msm8960 legacy HAL modules (e.g. display/libmemtrack/Android.mk) already use this exact LOCAL_HEADER_LIBRARIES pattern -- applied it here too.