fix: normalize JPG→JPEG format string before passing to Pillow#36
Open
TheSkyentist wants to merge 1 commit intoLeandroBarone:masterfrom
Open
fix: normalize JPG→JPEG format string before passing to Pillow#36TheSkyentist wants to merge 1 commit intoLeandroBarone:masterfrom
TheSkyentist wants to merge 1 commit intoLeandroBarone:masterfrom
Conversation
Pillow's Image.save() raises KeyError when given 'JPG' because it only recognises 'JPEG' as the JPEG format identifier. The public to_image_file() API advertises 'JPG' as a valid file_type, so normalise the alias at the call site rather than silently breaking. Add test_to_image_file_jpg to cover the previously-crashing code path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to_image_file()documentsfile_type='JPG'as a valid argument, but Pillow'sImage.save()only recognises'JPEG'— passing'JPG'raisesKeyError: 'JPG'at runtime._save_list_to_image_file, line 574) with a single conversion before theimg.save()call.test_to_image_file_jpgto cover the previously-crashing code path.Reproducer (before fix)
Test plan
test_to_image_file_jpgpasses (new test exercisingfile_type='JPG')test_to_image_file_*tests continue to pass (9/9)🤖 Generated with Claude Code