Appium 2 / W3C sample update (#12) without committed vendor/ and composer.phar - #14
Open
belaletech wants to merge 2 commits into
Open
belaletech wants to merge 2 commits into
belaletech wants to merge 2 commits into
Conversation
Remove the vendored Composer dependencies and the bundled composer.phar binary from version control, and add them to .gitignore. They are reproducible from composer.json/composer.lock via `composer install`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EPU3LJv3YRGtbssWicuJxb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #12 and drops the files that do not belong in version control.
Changes
AndroidApp.php,AndroidWeb.php,IOSApp.php,IOSWeb.php, refreshedcomposer.json/composer.lock, and README updates.vendor/tree (216 files remaining after Update PHP Appium samples to support Appium 2 and W3C capabilities #12) — it is reproducible withcomposer install.composer.pharbinary (2.8 MB)..gitignorenow covers/vendor/andcomposer.pharso they stay out.Why
#12 touches ~1,700 files, almost all of them vendored dependency churn, which makes the actual sample-code changes impossible to review. With
vendor/untracked, the reviewable surface is the 7 source/config files.Users run
composer install(documented in the README) to fetch dependencies, so nothing is lost.🤖 Generated with Claude Code
https://claude.ai/code/session_01EPU3LJv3YRGtbssWicuJxb