fix: use DAYS_PER_YEAR (365) for whole years in interval math#43
Open
adsharma wants to merge 1 commit into
Open
fix: use DAYS_PER_YEAR (365) for whole years in interval math#43adsharma wants to merge 1 commit into
adsharma wants to merge 1 commit into
Conversation
… conversion PyQueryResult::convertValueToPyObject (pybind path) and all interval conversion sites in _lbug_capi.py (C-API path) now use days = years * 365 + months * 30 + days instead of days = months * 30 + days This gives 365 days per whole year instead of 360, matching the engine's Interval::DAYS_PER_YEAR constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: LadybugDB/ladybug#694
PyQueryResult::convertValueToPyObject (pybind path) and all interval conversion sites in _lbug_capi.py (C-API path) now use
days = years * 365 + months * 30 + days
instead of
days = months * 30 + days
This gives 365 days per whole year instead of 360, matching the engine's Interval::DAYS_PER_YEAR constant.