Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7370111c9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| for function in iter_package_functions(): | ||
| executed_lines = executed_by_path.get(function.path, set()) | ||
| if not any(line in executed_lines for line in range(function.lineno, function.end_lineno + 1)): |
There was a problem hiding this comment.
Exclude function definition lines from coverage checks
check_function_coverage currently treats a function as covered if any line from lineno to end_lineno executed, but lineno includes the def statement itself, which coverage marks as executed when the module is imported even if the function body is never called. In practice this will under-report missing functions (especially for heavily imported modules), so the new CI report can claim functions were executed when only their definitions were loaded.
Useful? React with 👍 / 👎.
No description provided.