Skip to content

Reorganize tests, add coverage, report 20 not tested functions in ci/cd#598

Merged
DimaMolod merged 11 commits intomainfrom
tests
Mar 27, 2026
Merged

Reorganize tests, add coverage, report 20 not tested functions in ci/cd#598
DimaMolod merged 11 commits intomainfrom
tests

Conversation

@DimaMolod
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7370111c9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


for function in iter_package_functions():
executed_lines = executed_by_path.get(function.path, set())
if not any(line in executed_lines for line in range(function.lineno, function.end_lineno + 1)):
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Exclude function definition lines from coverage checks

check_function_coverage currently treats a function as covered if any line from lineno to end_lineno executed, but lineno includes the def statement itself, which coverage marks as executed when the module is imported even if the function body is never called. In practice this will under-report missing functions (especially for heavily imported modules), so the new CI report can claim functions were executed when only their definitions were loaded.

Useful? React with 👍 / 👎.

@DimaMolod DimaMolod merged commit 00aec34 into main Mar 27, 2026
5 checks passed
@DimaMolod DimaMolod deleted the tests branch March 27, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant