Abilities API: Shortcode Support#1100
Open
n7studios wants to merge 16 commits into
Open
Conversation
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
n7studios
requested review from
a team,
ciccio-kit and
noelherrick
and removed request for
a team
noelherrick
reviewed
May 28, 2026
noelherrick
left a comment
noelherrick
left a comment
Contributor
There was a problem hiding this comment.
This makes sense - I'm curious why you decided to go with regex matching of the HTML vs. using an HTML parsing library, specifically in get_element_offsets. Unless there's a strong reason against that, I would use real parsing.
ciccio-kit
reviewed
May 28, 2026
n7studios
changed the base branch from
abilities-api-restructure
to
abilities-api
…i-content-shortcode-support
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
ConvertKit_Shortcode_Post_Helperto support inserting, updating and deleting Kit elements (Forms, Form Triggers, Broadcasts, Products) as shortcodes from WordPress Pages and Posts.Removes the
indexparameter, as this isn't used.Testing
ShortcodePostHelperTest: Unit test inserting, updating and deleting Kit shortcodes from WordPress content.Checklist