Repository navigation
cube: roundtrip to ensure all globals are processed - #1268
Conversation
|
User mahkoh not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
User mahkoh not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
There was a problem hiding this comment.
🟢 Approval recommended
The focused change correctly ensures Wayland globals are processed and matches the existing C implementation.
0 open findings
What changed in this PR
Updates the C++ cube Wayland initialization to mirror the earlier C implementation fix in f993f97.
Changes:
- Uses a Wayland roundtrip to ensure registry globals are processed before initialization continues.
| File | Description |
|---|---|
cube/cube.cpp |
Replaces initial event dispatch with a synchronous registry roundtrip. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
CI Vulkan-Tools build queued with queue ID 152990. |
charles-lunarg
left a comment
charles-lunarg
left a comment
There was a problem hiding this comment.
The change is fine, but I cannot accept this PR until the CLA has been signed.
|
CI Vulkan-Tools build # 2060 running. |
It's not working even though it redirects me back to this PR. I have, however, already signed the CLA in other repos: KhronosGroup/Vulkan-ValidationLayers#11791 (comment) |
|
CI Vulkan-Tools build # 2060 passed. |
|
Could it be because I've reused the author from the original commit? Maybe the bot can't handle that. I can update the commit if so. |
|
Yes, it is worth trying. |
wl_display_dispatch() may not process all events. See f993f97
6dfacef to
8a7210c
Compare
|
User mahkoh not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
User mahkoh not on autobuild list. Waiting for curator authorization before starting CI build. |
|
Looks like that was it. |
wl_display_dispatch() may not process all events.
See f993f97