Repository navigation
check disable_all_explicit in enable_correct_layers_from_settings - #2108
Merged
charles-lunarg merged 1 commit intoNov 13, 2026
Merged
Conversation
When the loader settings file has layer configurations, the VK_LOADER_LAYERS_DISABLE check for "auto" layers tested disable_all_implicit for every layer and never looked at disable_all_explicit. ~explicit~ was ignored and ~implicit~ also removed explicit layers the application enabled. Pick the flag from the layer type, as loader_layer_is_available does.
|
User aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
User aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
|
CI Vulkan-Loader build queued with queue ID 197237. |
|
CI Vulkan-Loader build # 4000 running. |
|
CI Vulkan-Loader build # 4000 passed. |
charles-lunarg
approved these changes
Nov 13, 2026
charles-lunarg
left a comment
Collaborator
There was a problem hiding this comment.
Definitely an oversight, appreciate the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unpatched loader, new test
SettingsFile.VK_LOADER_LAYERS_DISABLE_ImplicitExplicitMatchLayerType,VK_LOADER_DEBUG=layer:VK_LAYER_Regular_TestLayer1is an explicit layer, set to "auto" in the settings file and enabled by the app.~implicit~drops it.~explicit~loads it.Found while comparing the two layer enable paths.
loader_enable_instance_layershands every decision toenable_correct_layers_from_settings.VK_LOADER_LAYERS_DISABLEcheck for "auto" layers testsdisable_all_implicitfor every layer. It never readsdisable_all_explicit.loader_layer_is_availableandloader_add_environment_layerspick the flag from the layer type.TestLayers.EnvironLayerEnableDisableExplicitLayercovers that path and passes.Conclusion: once a settings file is present,
~explicit~is ignored and an explicit layer requested by the app orVK_INSTANCE_LAYERSstill loads.~implicit~also strips explicit layers the app enabled. The fix picks the flag from the layer type, asloader_layer_is_availabledoes. Implicit layers see no change.The test puts one explicit and one implicit layer in the settings file as "auto". Unpatched it sees 0 active layers for
~implicit~and 2 for~explicit~, with 1 expected each time. It passes with the fix. Linux (GCC, Debug,BUILD_WERROR=ON): 694/694. macOS (Debug, ASAN): all pass exceptintegration.find_package, which fails the same way on the untouched tree here because of the local SDK setup. clang-format 16 clean.