Skip to content

add support for Sixel#133

Closed
IanButterworth wants to merge 1 commit into
masterfrom
ib/sixel
Closed

add support for Sixel#133
IanButterworth wants to merge 1 commit into
masterfrom
ib/sixel

Conversation

@IanButterworth

@IanButterworth IanButterworth commented Apr 15, 2025

Copy link
Copy Markdown
Collaborator

I think this is ok as a direct dep?
Also, needs testing.

If REFERENCETESTS_SIXEL=1

Screenshot 2025-04-15 at 1 04 20 PM

@oxinabox

Copy link
Copy Markdown
Member

Sixel actually adds a 50 direct dependencies, including ImageCore, which we currently use a hack to avoid depending on directly.
With that said maybe we should just depend on it (and ImageCore and XImageInTerm) directly,
making maintenance and use easier.

If we are depending on it directly, i think we don't need to use a enviroment variable to decide if to use it or not, and can just use Sixel.is_sixel_supported() and if so always use it. Its always better, no?

@IanButterworth

Copy link
Copy Markdown
Collaborator Author

Unfortunately that returns false inside the Pkg.test worker in a local terminal where it otherwise returns true.

@oxinabox

Copy link
Copy Markdown
Member

Oh thats annoying we should open an issue on Sixel.jl about that

@IanButterworth

Copy link
Copy Markdown
Collaborator Author

Attempts to fix it here JuliaIO/Sixel.jl#29

Pkg discussion about it here JuliaLang/Pkg.jl#3185 (comment)

@MasonProtter

Copy link
Copy Markdown
Member

I really want this and I'm fine with setting an env variable to get it FWIW.

@oxinabox

Copy link
Copy Markdown
Member

I propose the following things:

  • Fix CI
  • Add this to docs/readme
  • Open issue to do automatically once we workout how (cross link to the julia issue)
  • Remove @lazy loads from modules that are already loaded by Sixel.jl and if that is all of them remove dependency on LazyModules.jl

@IanButterworth

Copy link
Copy Markdown
Collaborator Author

Please feel free to take this over. It's not a high priority for me right now.

@oxinabox

oxinabox commented Nov 2, 2025

Copy link
Copy Markdown
Member

@MasonProtter are you interested in doing these things?

@MasonProtter

MasonProtter commented Nov 2, 2025

Copy link
Copy Markdown
Member

Yeah I can look into it during the week. Ill let you know the if I can take it on.

@MasonProtter MasonProtter mentioned this pull request Nov 8, 2025
4 tasks
@MasonProtter

Copy link
Copy Markdown
Member

Superseded by #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants