Repository navigation
Conversation
A call such as `f(x = 1)` at module scope was analyzed as an assignment to a global `x`, which made an explicit import of `x` look stale. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
===========================================
+ Coverage 66.49% 95.16% +28.67%
===========================================
Files 31 11 -20
Lines 6127 1593 -4534
===========================================
- Hits 4074 1516 -2558
+ Misses 2053 77 -1976 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A keyword argument passed in a call without a semicolon at module scope, such as
was analyzed as an assignment to a global
getindex.check_no_stale_explicit_importsthen reported the import as stale. The same call written asf(; getindex = 1), or placed inside a function body, was fine.is_kwarg_namerecognizedf(; x = 1)and named tuples, but notf(x = 1). It now does too, unless the call is a function signature with a default value (f(x = 1) = x), including one wrapped in a return type orwhereclause. The tests cover both cases.We ran into this with
$(MethodSignatures(defaults = true))from DocStringExtensions v0.10 in docstrings (CliMA/Oceananigans.jl#6263).🤖 Generated with Claude Code