Open
Conversation
Member
|
It's an interesting idea, but I wonder if it would be better to simply put an example of a loop over graphemes into the manual? |
Author
|
I think it's a great idea, but only probably because that's what I need. It's convenient to have it tested and ready to use. |
oold
reviewed
Mar 30, 2026
| const utf8proc_uint8_t *str, utf8proc_int32_t *read_bytes, utf8proc_ssize_t strlen, | ||
| utf8proc_uint32_t *start, utf8proc_uint32_t *end | ||
| ) { | ||
| int n, break_state = 0; |
There was a problem hiding this comment.
n should be a utf8proc_ssize_t.
break_state should be a utf8proc_int32_t .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wondering if you're interested in this, or at least as a starting point. The tests pass, but I expect faults to be found if you take a look.