Harden compiler-error display against disposed LLVM modules#854
Merged
Conversation
InvalidIRError retained a live LLVM.Instruction (from check_ir_values), so showing a caught error after its module was disposed segfaulted in Value::getName (e.g. Test rendering a failed test's exception). Snapshot the instruction to a string at construction, and route `show` through `showerror` for InvalidIRError/KernelError so display never field-dumps internal IR refs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
==========================================
- Coverage 79.49% 79.45% -0.04%
==========================================
Files 25 25
Lines 4769 4771 +2
==========================================
Hits 3791 3791
- Misses 978 980 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InvalidIRError retained a live LLVM.Instruction (from check_ir_values), so showing a caught error after its module was disposed segfaulted in Value::getName (e.g. Test rendering a failed test's exception). Snapshot the instruction to a string at construction, and route
showthroughshowerrorfor InvalidIRError/KernelError so display never field-dumps internal IR refs.