Metal: mark by-reference kernel arguments read-only#853
Merged
Conversation
`add_argument_metadata!` tagged every buffer argument `air.read_write`, but by-reference arguments (the kernel state, bitstype objects passed by pointer) are loaded into a stack slot at function entry and never written back through the argument pointer -- any device pointers they contain address separate, independently-bound buffers. Tagging them `air.read` lets a host bind them with read-only data (Metal's `setBytes:`) without API validation rejecting read-only bytes bound to a write-accessible argument. Genuine pointer-to-data arguments (`Ptr`/`LLVMPtr` bound to a real buffer) stay read-write. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
=======================================
Coverage 79.48% 79.49%
=======================================
Files 25 25
Lines 4767 4769 +2
=======================================
+ Hits 3789 3791 +2
Misses 978 978 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_argument_metadata!tagged every buffer argumentair.read_write, but by-reference arguments (the kernel state, bitstype objects passed by pointer) are loaded into a stack slot at function entry and never written back through the argument pointer -- any device pointers they contain address separate, independently-bound buffers. Tagging themair.readlets a host bind them with read-only data (Metal'ssetBytes:) without API validation rejecting read-only bytes bound to a write-accessible argument. Genuine pointer-to-data arguments (Ptr/LLVMPtrbound to a real buffer) stay read-write.