Align runtime datalayout when relinking after non-integral stripping#852
Merged
Conversation
The post-GC-lowering runtime relink runs after `RemoveNIPass` has stripped Julia's non-integral address spaces from the module datalayout, while the cached runtime library still carries them. This produced a spurious "Linking two modules of different data layouts" warning during (pre)compilation. Align the runtime's triple and datalayout to the destination before linking, mirroring how target libraries (e.g. libdevice) are linked. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
=======================================
Coverage 79.84% 79.85%
=======================================
Files 25 25
Lines 4738 4740 +2
=======================================
+ Hits 3783 3785 +2
Misses 955 955 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post-GC-lowering runtime relink runs after
RemoveNIPasshas stripped Julia's non-integral address spaces from the module datalayout, while the cached runtime library still carries them. This produced a spurious "Linking two modules of different data layouts" warning during (pre)compilation.Align the runtime's triple and datalayout to the destination before linking, mirroring how target libraries (e.g. libdevice) are linked.
Fixes JuliaGPU/CUDA.jl#3177