Fix isstable for discrete Dual state-space to check eigenvalues#1057
Merged
Conversation
The discrete `ForwardDiff.Dual` specialization of `isstable` compared the magnitudes of `A`'s entries against 1 instead of the magnitudes of its eigenvalues, which is unrelated to discrete-time stability. For example, `A = 0.9*ones(2,2)` has all entries below 1 but eigenvalue 1.8. Now mirrors the continuous-time `ForwardDiff.Dual` specialization on the line above and uses `eigvals` to evaluate the stability criterion. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This is an automated message.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1057 +/- ##
=======================================
Coverage 91.61% 91.61%
=======================================
Files 42 42
Lines 5653 5653
=======================================
Hits 5179 5179
Misses 474 474 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Summary
The
isstablespecialization forStateSpace{<:Discrete, <:ForwardDiff.Dual}checked|A[i,j]| < 1element-wise rather than|λ(A)| < 1. This is unrelated to discrete-time stability.Example counter-example before the fix:
The continuous-time
Dualspecialization immediately above already useseigvalscorrectly; this aligns the discrete one with it.Test plan
isstablereturnsfalse.🤖 Generated with Claude Code