Remove LLVM 20 limitation#485
Open
MathewBensonCode wants to merge 1 commit intoJeanPhilippeKernel:developfrom
Open
Remove LLVM 20 limitation#485MathewBensonCode wants to merge 1 commit intoJeanPhilippeKernel:developfrom
MathewBensonCode wants to merge 1 commit intoJeanPhilippeKernel:developfrom
Conversation
JeanPhilippeKernel
requested changes
Jan 16, 2026
| if ($IsLinux) { | ||
| '/usr/bin/clang-format' | ||
| '/usr/bin/clang-format-21' | ||
| '/usr/bin/clang-format-20' |
There was a problem hiding this comment.
That means we want to remove the clang-format-20 from candidate list
Contributor
Author
There was a problem hiding this comment.
I thought to leave it in as a precaution incase someone is still on the older platform. The main idea was to remove the restriction on newer versions but that compatibility with the older version is retained as specified in repoConfig.json
MathewBensonCode
force-pushed
the
update-llvm
branch
from
fa70173 to
3e0a9fc
Compare
MathewBensonCode
force-pushed
the
update-llvm
branch
from
3e0a9fc to
8ad3db9
Compare
- clang-format ignore on CoroutineScheduler.h and VulkanDevice.h for operator bool() - update ubuntu CI workflow to use version 21 as it tends to be behind in its inbuild version
MathewBensonCode
force-pushed
the
update-llvm
branch
from
8ad3db9 to
2582656
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #484