Skip to content

Does net.sf.jsqlparser.statement.Statement thread safe? #1627

Closed
Closed
Does net.sf.jsqlparser.statement.Statement thread safe?#1627

Description

@leotu
leotu
opened on Sep 12, 2022

Should I reusing Statement increases performance？

protected final Map<String, Statement> statementCaches = Collections.synchronizedMap(new WeakHashMap<>());
...
Statement stmt = CCJSqlParserUtil.parse(sql)
...
statementCaches.computeIfAbsent(sql, stmt);
...

Activity

  1. manticore-projects commented on Sep 12, 2022

    @manticore-projects
    manticore-projects
    on Sep 12, 2022
    Contributor

    Greetings.

    You can certainly cache Statements if you are in a situation when you would have to parse similar, but very complex statements many times. Although I have a hard time to construe such a situation.

    The more interesting challenge was to decide when a statement is equal. It would depend on a reliable hash of the SQL String -- after replacing any fixed Values (String, Boolean, Double, Long, Date) with parameters.

    Determining this hash would depend on parsing the statement -- defeating the purpose.

    Long story short: you can cache statements but I wonder why you would want to do that. Maybe you will need to elaborate on the exact challenge you want to overcome.

    Cheers.

  2. manticore-projects
    converted this issue into a discussion #1628 on Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions