Skip to content

require ecflow for ewok-env#1989

Merged
climbfuji merged 3 commits intoJCSDA:developfrom
ashley314:feature/ecflow4ewokenv
Apr 22, 2026
Merged

require ecflow for ewok-env#1989
climbfuji merged 3 commits intoJCSDA:developfrom
ashley314:feature/ecflow4ewokenv

Conversation

@ashley314
Copy link
Copy Markdown
Collaborator

@ashley314 ashley314 commented Apr 15, 2026 •
edited by climbfuji
Loading

Description

Add the ecflow requirement for ewok-env to JCSDA used HPCs.

Dependencies

None

Issues addressed

Closes #1980

Applications affected

EWOK/Skylab

Systems affected

Orion, Hercules, Derecho

Testing

  • CI: Note whether the automatic tests (GitHub actions tests that run automatically for every commit) pass or not
    • GitHub actions CI tests pass
    • GitHub actions CI tests do not pass (provide explanation)
    • GitHub actions CI tests skipped (provide explanation if necessary)
  • New tests added: List and describe any new tests added to GitHub actions
    • ...
  • Additional testing: Add information on any additional tests conducted
    • ...

Checklist

  • This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications. <- tested on discover and aws-ubuntu
  • All dependency PRs/issues have been resolved and this PR can be merged.
  • All necessary updates to the documentation (spack-stack wiki) will be made when this PR is merged

@ashley314 ashley314 self-assigned this Apr 15, 2026
@ashley314 ashley314 added the INFRA JEDI Infrastructure label Apr 15, 2026
@ashley314 ashley314 marked this pull request as ready for review April 15, 2026 19:25
climbfuji
climbfuji reviewed Apr 15, 2026
View reviewed changes
Comment thread configs/sites/tier1/hercules/packages.yaml Outdated
climbfuji
climbfuji reviewed Apr 15, 2026
View reviewed changes
Comment thread configs/sites/tier1/orion/packages.yaml Outdated
climbfuji
climbfuji approved these changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicky :-)

@ashley314 @climbfuji
comments
17df88d 
Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
@ashley314 ashley314 requested a review from eap April 15, 2026 20:15
@climbfuji
Copy link
Copy Markdown
Collaborator

climbfuji commented Apr 22, 2026

@eap Can you sign off on this, please?

eap
eap approved these changes Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@eap eap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@climbfuji climbfuji requested a review from jim-p-w April 22, 2026 22:46
@climbfuji
Copy link
Copy Markdown
Collaborator

climbfuji commented Apr 22, 2026

@jim-p-w tagging you for your awareness (derecho site config update)

@climbfuji climbfuji removed the request for review from jim-p-w April 22, 2026 22:47
@climbfuji climbfuji merged commit 39a43a1 into JCSDA:develop Apr 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@climbfuji climbfuji climbfuji approved these changes

@eap eap eap approved these changes

Assignees

@ashley314 ashley314

Labels

INFRA JEDI Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Require ecflow for ewok env on JCSDA used HPCs

3 participants

@ashley314 @climbfuji @eap