Wrong behavior in float values using IronPython in a C# application #841

Activity

1. slozier commented on Aug 22, 2024

   

   slozier

   on Aug 22, 2024

   Contributor

   More actions

   How are you passing the parameters from .NET to Python? It's hard to tell what your doing from the description above. An example to reproduce the issue would be helpful...
2. jandres861 commented on Aug 22, 2024

   

   jandres861

   on Aug 22, 2024

   Last edited by slozier

   Author

   More actions

   How are you passing the parameters from .NET to Python? It's hard to tell what your doing from the description above. An example to reproduce the issue would be helpful...

   Hi, thanks for your quick answer. Let me write some example of the code here, limited as by my company's IT policies ( I'm trying to include screenshots but is not possible for some reason)

   //Create the Runtime
   public RuntimeProvider()
           {
               // set the callback to log errors.
               var options = new Dictionary<string, object>();
               options["Debug"] = false;
   
               // Creates execution engine
               this.myEngine = Python.CreateEngine(options);
   
               // This is for debugging Python code
               // this.myEngine.SetTrace(this.OnTraceback);
               this.myScope = this.myEngine.CreateScope();
           }
   
   // Load the script
   public void LoadScript(string scriptSource, bool sameScope, bool sourceIsFileName)
           {
              
                   this.ScriptScope = this.RuntimeProvider.CreateScope();
                          ScriptSource source;
   
                            source = this.RuntimeProvider.Engine.CreateScriptSourceFromString(scriptSource);
            
               ScriptSources.Add(source);
               
               var compiled = source.Compile();
               this.myExecutions.Add(compiled.Execute(this.ScriptScope));
           }
   
   // Proxy
           private TcoAlgorithmProxy LoadAlgorithmInstance(string algorithmCode, string algorithmDescriptionBuilder)
           {
               var scriptLoader = new ScriptLoader();
               var pythonInstance = this.LoadAlgorithm(algorithmCode, algorithmDescriptionBuilder, scriptLoader);
   
               // Creates the proxy to comunicate the code with the other application domain
               // This proxy is neccesary because the object that you want to sent to the other domain must intherit from MarshalByRefObject
               var algorithm = new AlgorithmProxy(pythonInstance, scriptLoader.RuntimeProvider.Engine);
               return algorithm;
           }
   
   
   // Call function
   protected override double? GetValue(IClusterableFeature anomaly)
           {
               var ffsLoss = this.FfsAssessement.GetMaxIliFfsLoss(anomaly, lineType.Value, inBend.Value, pipeGrade.Value, anomaly.AddTolerance);
               return ffsLoss.Value;
           }
   
   // Specific function call in python
   public double GetMaxIliFfsLoss(
               string lineType,
               double wallThicknessInMeter,
               double designFactor,
               bool inBend,
               string pofDefectClass,
               double lengthInMeter,
               double widthInMeter,
               double depthPercentage,
               double designPressureInMpa,
               string pipeGrade,
               double outerDiameterInMeter,
               bool addTolerance)
           {
               return this.GetValue(
                   () => this.myPythonAlgorithmInstance.GetMaxIliFfsLoss(
                       lineType,
                       wallThicknessInMeter,
                       designFactor,
                       inBend,
                       wallThicknessInMeter.ToString("R"),
                       lengthInMeter,
                       widthInMeter,
                       depthPercentage,
                       designPressureInMpa,
                       pipeGrade,
                       outerDiameterInMeter,
                       addTolerance));

   And finally the simplified code in Python that is being executed:

   def GetMaxIliFfsLoss(self,
   lineType,
   wallThicknessInMeter,
   designFactor,
   inBend,
   pofDefectClass,
   lengthInMeter,
   widthInMeter,
   depthPercentage,
   designPressureInMpa,
   pipeGrade,
   outerDiameterInMeter,
   addTolerance):
   if not isinstance(wallThicknessInMeter, float):
   culture = CultureInfo.CurrentCulture
   number = 0.00950000
   numberStr = number.ToString(culture.NumberFormat)
   raise Exception("WT: " + str(wallThicknessInMeter), lineType,
   type(wallThicknessInMeter),
   "Float Number: ",
   number,
   "Float Number String",
   numberStr,
   "Convert From String To Float",
   Double.Parse("0.0095"),
   "Culture Number Format",
   culture.NumberFormat,
   designFactor,
   inBend,
   pofDefectClass,
   float(pofDefectClass),
   lengthInMeter,
   widthInMeter,
   depthPercentage,
   addTolerance,
   designPressureInMpa,
   pipeGrade,
   outerDiameterInMeter)

   And just using that RaiseError to print in the .NET Exception the values we identified the change to that very small numbers, not the desired ones.
3. slozier commented on Aug 26, 2024

   

   slozier

   on Aug 26, 2024

   Contributor

   More actions

   It's interesting that Double.Parse("0.0095") would give you 1.034294700449062e-311. Is the code only failing once in a while or is it consistently incorrect? Unfortunately I haven't been able to reproduce. Which version of IronPython 2.7 and of the DLR are you using?
4. jandres861 commented on Aug 26, 2024

   

   jandres861

   on Aug 26, 2024

   Author

   More actions

   It's interesting that Double.Parse("0.0095") would give you 1.034294700449062e-311. Is the code only failing once in a while or is it consistently incorrect? Unfortunately I haven't been able to reproduce. Which version of IronPython 2.7 and of the DLR are you using?

   As we are iterating over several calls to the python functions, the code works well in the first ones but after that starts to fail and we could never have a full execution of the algorithm.

   The specific version of IronPython is 2.7.9. The solution is build in .NET framework 4.7.2. Seems also related with the Microsoft.Scripting 1.2.2.0.

   Thanks!