Merged
Conversation
Fix failure: Method 'ValidateKeyProperty' in type 'Microsoft.SemanticKernel.Connectors.PgVector.PostgresModelBuilder' from assembly 'Microsoft.SemanticKernel.Connectors.PgVector, Version=1.70.0.0, Culture=neutral, PublicKeyToken=f300afd708cefcd3' does not have an implementation.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns Semantic Kernel PgVector connector versioning with the Semantic Kernel core package to prevent runtime TypeLoadException failures in the Chat components, and adds a regression test to catch future mismatches.
Changes:
- Centralized the Semantic Kernel version into
SemanticKernelVersionand alignedMicrosoft.SemanticKernel.Connectors.PgVectorto that version. - Added a regression test to ensure
PostgresVectorStore.GetCollectiondoesn’t fail withTypeLoadExceptiondue to SK package mismatches. - Ignored
TestResults/artifacts.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| EssentialCSharp.Chat.Tests/PgVectorConnectorTests.cs | Adds a regression test covering the previously observed TypeLoadException failure mode. |
| Directory.Packages.props | Aligns SK core and PgVector connector versions via a shared SemanticKernelVersion property. |
| .gitignore | Adds TestResults/ to ignored outputs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Method 'ValidateKeyProperty' in type 'Microsoft.SemanticKernel.Connectors.PgVector.PostgresModelBuilder' from assembly 'Microsoft.SemanticKernel.Connectors.PgVector, Version=1.70.0.0, Culture=neutral, PublicKeyToken=f300afd708cefcd3' does not have an implementation.
Ensure that your pull request has followed all the steps below: