COMP: Remove unused InputPixelType aliases in CopyIterationBenchmark#115
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Apr 24, 2026
Conversation
CopyRegionIterator and CopyScanlineIterator declared InputPixelType but never referenced it, triggering -Wunused-local-typedef. Other methods (CopyMemcpy, CopyImageRegionRange) still use the alias where it is needed and are left unchanged.
dzenanz
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove two unused `using InputPixelType = typename TInputImage::PixelType;` declarations in `CopyRegionIterator` and `CopyScanlineIterator`. The other benchmark methods still use the alias and are unchanged.
Warning being fixed
```
itkCopyIterationBenchmark.cxx:78:9: warning: unused type alias 'InputPixelType' [-Wunused-local-typedef]
itkCopyIterationBenchmark.cxx:101:9: warning: unused type alias 'InputPixelType' [-Wunused-local-typedef]
```
(line numbers from the ITK Remote-Modules build tree; direct sources are lines 119 and 142.)