Repository navigation
STYLE: Mark the sources for the ITK style checks and format them - #3
Merged
Merged
Conversation
The clang-format linter action now fails when no tracked file carries hooks.style=clangformat; without a .gitattributes it had been passing without checking a file. Mark the C++ sources as ITK marks its own and apply clang-format 19.1.7 with the module's .clang-format: whitespace and line breaks only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clang-format linter (
ITKClangFormatLinterAction@main) now fails when no tracked file carrieshooks.style=clangformat. This repository had no.gitattributes, so the check had been passing without reading a file, and it is red on every branch today..gitattributesmarks*.h,*.hxxand*.cxxthe way ITK marks its own sources..clang-format.The reformat changes whitespace and line breaks only: each file is byte-identical to its previous version once spaces, tabs and newlines are removed.
SortIncludesisNever, so no include moves. Every header still compiles on its own.