COMP: Declare ITKIOImageBase for BoneMorphometry wrapping - #6880
Merged
hjmjohnson merged 1 commit intoSep 21, 2026
Merged
hjmjohnson merged 1 commit into
hjmjohnson merged 1 commit into
Conversation
itkBoneCommon.wrap wraps itk::ImageIOBase, itk::ImageFileReader and itk::ImageFileWriter, all of which are declared in ITKIOImageBase, but the module never depended on it. The generated wrapping sources therefore failed with "itkImageIOBase.h file not found". The module is EXCLUDE_FROM_DEFAULT, so no dashboard configuration builds its wrapping and the missing dependency went unnoticed.
dzenanz
approved these changes
Sep 21, 2026
hjmjohnson
marked this pull request as ready for review
September 21, 2026 19:12
Contributor
|
hjmjohnson
merged commit Sep 21, 2026
fa4b2d3
into
InsightSoftwareConsortium:main
16 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
itkBoneCommon.wrapwrapsitk::ImageIOBase,itk::ImageFileReader, anditk::ImageFileWriter, which are declared inITKIOImageBase, but the module never depended on it. Declaring it fixesitkImageIOBase.h file not foundwhen building this module's Python wrapping.How this was found, and why it went unnoticed
Found while building ITK with every
EXCLUDE_FROM_DEFAULTmodule enabled, to test whether the ITK Python wheel cache could ship the ingested remote modules.BoneMorphometryisEXCLUDE_FROM_DEFAULT, so no dashboard configuration builds it, and nothing has ever compiled its generated wrapping sources. Three wrapping translation units fail without this change:COMPILE_DEPENDSis the right list: the dependency is needed to compile the wrapping sources, not to link the module library.Verification
Configured with
-DModule_BoneMorphometry=ON -DITK_WRAP_PYTHON=ONon macOS arm64.ninja BoneMorphometryPythoncompiles all five translation units and links_BoneMorphometryPython.abi3.so.pre-commit run --all-filesexits 0.