Skip to content

Add escaped quotes to LINK_FLAGS - #2493

Merged
mark9064 merged 1 commit into
InfiniTimeOrg:mainfrom
margotfrison:fix-build-with-space-parent-folder
Oct 17, 2026
Merged

mark9064 merged 1 commit into
InfiniTimeOrg:mainfrom
margotfrison:fix-build-with-space-parent-folder

Conversation

@margotfrison

@margotfrison margotfrison commented Oct 16, 2026 •

Copy link
Copy Markdown

Suggested fix for the issue #2492.

Not sure if it can be done more cleanly, but I did this pull request so you don't have to.

I've built the project with and without a space in the parent folder with this fix. It worked fine for both cases.

Please note that you have to recreate the .venv python virtual environment when changing the folder hierarchy to test my changes.

@github-actions

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 387984B 0B
data 936B 0B
bss 22936B 0B

Run in InfiniEmu

@mark9064 mark9064 added the maintenance Background work label Oct 17, 2026
@mark9064

Copy link
Copy Markdown
Member

Thanks for the PR :)

@mark9064
mark9064 merged commit bbee39e into InfiniTimeOrg:main Oct 17, 2026
5 checks passed
@mark9064 mark9064 linked an issue Oct 17, 2026 that may be closed by this pull request
1 task done
@mark9064 mark9064 added this to the 1.17.0 milestone Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Background work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to build when a parent folder contains a space (linker error)

2 participants