Feature/gphwpp 4432 move jetpack and login to core - #920
Open
peperuda-dev wants to merge 16 commits into
Open
peperuda-dev wants to merge 16 commits into
peperuda-dev wants to merge 16 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the login branding/tracking and Jetpack backup coupon flow functionality from the ionos-essentials plugin into the ionos-core mu-plugin, while adding guards in ionos-essentials to avoid double-loading when ionos-core provides the same features.
Changes:
- Add
ionos-corelogin module (PHP enqueue + header branding, plus JS tracking + CSS styling) and an accompanying Playwright E2E test. - Add
ionos-coreJetpack flow module (admin flow + assets + README) and load it fromionos-core.php. - Add “already loaded” guards to
ionos-essentialslogin + Jetpack flow modules.
Reviewed changes
Copilot reviewed 10 out of 18 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/wp-plugin/ionos-essentials/ionos-essentials/inc/login/index.php | Adds guard to skip if core already loaded; adjusts tenant-logo URL generation. |
| packages/wp-plugin/ionos-essentials/ionos-essentials/inc/jetpack-flow/index.php | Adds guard to skip if core already loaded. |
| packages/wp-mu-plugin/ionos-core/ionos-core/src/login/index.js | New login JS to track SSO clicks via REST endpoint. |
| packages/wp-mu-plugin/ionos-core/ionos-core/src/login/index.css | New login CSS for header/logo styling. |
| packages/wp-mu-plugin/ionos-core/ionos-core/login/index.php | New login PHP to enqueue assets and inject branded header. |
| packages/wp-mu-plugin/ionos-core/ionos-core/login/tests/e2e/login.spec.js | New Playwright E2E test for login branding and console errors. |
| packages/wp-mu-plugin/ionos-core/ionos-core/login/assets/tenant-logos/*.svg | Adds tenant logo assets for login header branding. |
| packages/wp-mu-plugin/ionos-core/ionos-core/jetpack-flow/index.php | New Jetpack backup coupon flow implementation in core. |
| packages/wp-mu-plugin/ionos-core/ionos-core/jetpack-flow/assets/flow.css | New styling for the Jetpack flow admin UI. |
| packages/wp-mu-plugin/ionos-core/ionos-core/jetpack-flow/assets/jetpack-logo.svg | Adds Jetpack logo asset used by the flow UI. |
| packages/wp-mu-plugin/ionos-core/ionos-core/jetpack-flow/README.md | Adds developer documentation for the Jetpack flow. |
| packages/wp-mu-plugin/ionos-core/ionos-core.php | Defines core plugin constants, adds _is_plugin_active(), and loads jetpack-flow/login modules. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ttps://github.com/IONOS-WordPress/ionos-wordpress into feature/GPHWPP-4432-move-jetpack-and-login-to-core
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tobibode
reviewed
Aug 30, 2026
| if (! function_exists('delete_plugins')) { | ||
| require_once ABSPATH . 'wp-admin/includes/plugin.php'; | ||
| } | ||
| \delete_plugins([ESSENTIALS_PLUGIN]); |
Contributor
There was a problem hiding this comment.
this is definitely not the wanted behavior.
https://hosting-jira.1and1.org/browse/GPHWPP-4429 would be solved by deleting assistant, but please not essentials as it's supposed to work next to core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Screenshots / Recordings
If the ui was changed by PR please provide a screenshot
manual testing
Please replace this line with instructions on how to test your changes
Reviewer checklist