Skip to content

Close the quote in the custom-mirror stub rule - #52

Merged
gouttegd merged 1 commit into
mainfrom
fix-custom-mirror-stub-quote
Oct 27, 2026
Merged

gouttegd merged 1 commit into
mainfrom
fix-custom-mirror-stub-quote

Conversation

@matentzn

Copy link
Copy Markdown
Contributor

The first echo in the mirror_type: custom stub was missing its closing quote, so the error message was replaced by a shell syntax error.

{% if ont.mirror_type == 'custom' -%}
$(MIRRORDIR)/{{ ont.id }}.owl:
@echo "ERROR: You have configured your default mirror type to be custom;
@echo "ERROR: You have configured your default mirror type to be custom;"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We critically need a much more comprehensive test suite…

Thanks!

@gouttegd
gouttegd merged commit befd181 into main Oct 27, 2026
6 checks passed
@gouttegd
gouttegd deleted the fix-custom-mirror-stub-quote branch October 27, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants