Use pset midpoint in map projection at l2#2862
Merged
lacoak21 merged 3 commits intoIMAP-Science-Operations-Center:devfrom Mar 24, 2026
Merged
Conversation
lacoak21
commented
Mar 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ENA map pointing-set frame transformations to use the pointing-set midpoint ET (instead of start epoch) to avoid SPICE attitude coverage gaps during L2 map projection (fix for #2582).
Changes:
- Use
epoch + epoch_delta/2(midpoint TTJ2000) when derivingevent_etfor PSET↔Map coordinate transformations. - Add
PointingSet.epoch_deltaconvenience property. - Extend ULTRA PSET test fixtures and add a basic assertion for
epoch_delta.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
imap_processing/ena_maps/ena_maps.py |
Switches default transform time to PSET midpoint and introduces epoch_delta property. |
imap_processing/tests/ultra/mock_data.py |
Mocks epoch_delta in ULTRA L1C healpix PSET test dataset. |
imap_processing/tests/ena_maps/test_ena_maps.py |
Adds an assertion that UltraPointingSet.epoch_delta is present and returns the mocked value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
408591a
into
IMAP-Science-Operations-Center:dev
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
closes #2582
Overview
Menlo found a bug in which some pset epoch times did not have pointing attitude coverage. This was due to a small conversion error. See #2582 for more info.
Tim/ menlo suggested using the midpoint ET of the pointing instead of the start.
File changes
imap_processing/ena_maps/ena_maps.py
Testing
Add a small test to make sure epoch_delta returns the correct value