Repository navigation
Update column renaming method to be consistent with pandas 3.1.0 syntax - #177
Merged
Merged
Conversation
ksbeattie
approved these changes
Oct 29, 2026
ksbeattie
left a comment
Member
There was a problem hiding this comment.
LGTM, though I'd also like to have another review here.
There was a problem hiding this comment.
🟡 Changes recommended
The change incorrectly labels entropy predictions as flow_mol and modifies only a generated notebook, leaving the source unchanged and causing regeneration to discard the fix.
2 open issues
What changed in this PR
This PR updates column assignment in the supercritical CO₂ Keras training test notebook for pandas compatibility and pins a pre-commit hook for reproducible checks.
Changes:
- Replaces mutation of
columns.valueswith assignment tocsv_data.columns, while also changing three column labels. - Pins
nbstripoutto0.9.1instead ofmaster.
| File | Description |
|---|---|
idaes_examples/notebooks/docs/surrogates/sco2/omlt/keras_training_test.ipynb |
Updates column assignment syntax and labels in the generated test notebook. |
.pre-commit-config.yaml |
Pins the notebook output-stripping hook to a fixed release. |
Review effort: Balanced
Comment on lines
+160
to
+162
| " \"flow_mol\",\n", | ||
| " \"mole_frac_comp_1\",\n", | ||
| " \"mole_frac_comp_2\",\n", |
| " \"mole_frac_comp_2\",\n", | ||
| "]\n", | ||
| "\n", | ||
| "csv_data.columns = new_names + list(csv_data.columns[6:])\n", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request makes a minor update to the
.pre-commit-config.yamlfile, pinning thenbstripoutpre-commit hook to version0.9.1instead of using themasterbranch. This change improves reproducibility and stability for pre-commit checks.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
📚 Documentation preview 📚: https://idaes-examples--177.org.readthedocs.build/en/177/