Skip to content

Update column renaming method to be consistent with pandas 3.1.0 syntax - #177

Merged
dallan-keylogic merged 9 commits into
IDAES:mainfrom
sufikaur:pandas-3.1.0
Oct 30, 2026
Merged

dallan-keylogic merged 9 commits into
IDAES:mainfrom
sufikaur:pandas-3.1.0

Conversation

@sufikaur

@sufikaur sufikaur commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

This pull request makes a minor update to the .pre-commit-config.yaml file, pinning the nbstripout pre-commit hook to version 0.9.1 instead of using the master branch. This change improves reproducibility and stability for pre-commit checks.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

📚 Documentation preview 📚: https://idaes-examples--177.org.readthedocs.build/en/177/

@sufikaur sufikaur self-assigned this Oct 29, 2026
@sufikaur
sufikaur requested a review from ksbeattie October 29, 2026 00:10

@ksbeattie ksbeattie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'd also like to have another review here.

@ksbeattie
ksbeattie requested a balanced review from Copilot October 29, 2026 00:12
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Oct 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The change incorrectly labels entropy predictions as flow_mol and modifies only a generated notebook, leaving the source unchanged and causing regeneration to discard the fix.

2 open issues
What changed in this PR

This PR updates column assignment in the supercritical CO₂ Keras training test notebook for pandas compatibility and pins a pre-commit hook for reproducible checks.

Changes:

  • Replaces mutation of columns.values with assignment to csv_data.columns, while also changing three column labels.
  • Pins nbstripout to 0.9.1 instead of master.
File Description
idaes_examples/​notebooks/​docs/​surrogates/​sco2/​omlt/​keras_training_test.ipynb Updates column assignment syntax and labels in the generated test notebook.
.pre-commit-config.yaml Pins the notebook output-stripping hook to a fixed release.

Review effort: Balanced

Comment on lines +160 to +162
" \"flow_mol\",\n",
" \"mole_frac_comp_1\",\n",
" \"mole_frac_comp_2\",\n",
" \"mole_frac_comp_2\",\n",
"]\n",
"\n",
"csv_data.columns = new_names + list(csv_data.columns[6:])\n",
@dallan-keylogic
dallan-keylogic merged commit eb64e38 into IDAES:main Oct 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants