Skip to content

Remove _CRT_SECURE_NO_DEPRECATE from the haxe toolchain#1160

Merged
Simn merged 1 commit intoHaxeFoundation:masterfrom
MAJigsaw77:patch-3
Mar 17, 2026
Merged

Remove _CRT_SECURE_NO_DEPRECATE from the haxe toolchain#1160
Simn merged 1 commit intoHaxeFoundation:masterfrom
MAJigsaw77:patch-3

Conversation

@MAJigsaw77
Copy link
Contributor

No description provided.

@tobil4sk
Copy link
Member

tobil4sk commented Aug 2, 2025

Here is a page from the microsoft docs which mentions the define, confirming that it's windows-specific: https://github.com/MicrosoftDocs/cpp-docs/blob/25815cbe0dd6bae018890dd85eb10e5e5feece8e/docs/c-runtime-library/security-features-in-the-crt.md

@tobil4sk
Copy link
Member

tobil4sk commented Sep 8, 2025

I noticed, the msvc toolchain already adds this flag for all msvc builds:

<flag value="-D_CRT_SECURE_NO_DEPRECATE"/>

So I wonder if it's safe to remove it from haxe-target.xml?

@MAJigsaw77
Copy link
Contributor Author

I noticed, the msvc toolchain already adds this flag for all msvc builds:

<flag value="-D_CRT_SECURE_NO_DEPRECATE"/>

So I wonder if it's safe to remove it from haxe-target.xml?

Perhaps, if it doesnt break anything.

@MAJigsaw77 MAJigsaw77 changed the title Don't define _CRT_SECURE_NO_DEPRECATE on non-windows targets. Remove _CRT_SECURE_NO_DEPRECATE from the haxe toolchain Mar 17, 2026
@tobil4sk
Copy link
Member

@Simn this is also a good fix, we don't want to polute non-msvc builds with a msvc specific flag

@Simn Simn merged commit acef6fa into HaxeFoundation:master Mar 17, 2026
133 checks passed
@MAJigsaw77 MAJigsaw77 deleted the patch-3 branch March 17, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants