fix: resolve properties backed by default interface members - #658
Merged
Conversation
Type.GetProperties() on a concrete class doesn't surface properties whose
only implementation is a C# 8+ default interface member, so {{PropertyName}}
and {{#each this}} silently skipped them. Both reflection lookups now also
scan the instance type's implemented interfaces.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
rexm
enabled auto-merge
August 6, 2026 02:41
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type.GetProperties()on a concrete class doesn't surface properties whose only implementation is a C# 8+ default interface member (declared and bodied on an interface, not overridden by the class). Both{{PropertyName}}lookup (ReflectionMemberAccessor) and property enumeration (ObjectDescriptorProvider, used by{{#each this}}) now also scan the instance type's implemented interfaces as a fallback.PropertyInfo.GetValue/CreateDelegateon an interface-declared property correctly dispatches to the default implementation for a concrete instance, so no change was needed to the existing delegate-binding code.Fixes #601.
Test plan
Issue601_DefaultInterfaceMemberPropertyIsResolvedandIssue601_DefaultInterfaceMemberPropertyIsEnumeratedinIssueTests.cs, reproducing the exact interface/class shape from the issue.🤖 Generated with Claude Code