fix: support hash arguments for inline partials - #647
Merged
Conversation
InlineBlockDecoratorDescriptor required the {{#*inline "name"}} decorator
to receive exactly one argument, so passing any extra positional or hash
argument on the inline definition (e.g. {{#*inline "name" arg}}) threw at
runtime. Relax the check to only require the partial name, matching
Handlebars.js which uses args[0] for the name and ignores the rest.
Hash arguments passed when invoking an inline partial (e.g.
{{> myPartial key=value}}) already worked via the shared PartialBinder
context-creation path used by both inline and registered partials.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{{#*inline "name" ...}}decorator required exactly 1 argument, so passing hash arguments (or any extra positional arg) threwHandlebarsRuntimeException. Relaxed the check to only require the partial name argument, ignoring extras — matching Handlebars.js's owninlinedecorator behavior.{{> myPartial key=value}}) already worked identically for inline and registered partials; that path was unaffected.Test plan
InlinePartialTests.cscovering the issue's exact repro plus a hash-argument variantFixes #560
🤖 Generated with Claude Code