Skip to content

Temporarily disable blosc2 testing from development git branch #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajelenak merged 1 commit into from
May 6, 2026
Merged

Temporarily disable blosc2 testing from development git branch #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/main-fetchcontent-mac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ permissions:

jobs:
# Test building filter libraries and hdf5_plugins project inline with CMake's
# FetchContent (git) functionality while building HDF5.
# FetchContent (tgz) functionality while building HDF5.
build_and_test_inline:
name: "MacOS Clang (hdf5_plugins built inline with HDF5)"
runs-on: macos-latest
Expand Down Expand Up @@ -69,7 +69,7 @@ jobs:
-DHDF5_ENABLE_PLUGIN_SUPPORT=ON \
-DPLUGIN_USE_EXTERNAL=ON \
-DPLUGIN_USE_LOCALCONTENT=OFF \
-DH5PL_ALLOW_EXTERNAL_SUPPORT=GIT \
-DH5PL_ALLOW_EXTERNAL_SUPPORT=TGZ \
-DH5PL_BUILD_TESTING=ON \
-DH5PL_BUILD_EXAMPLES=ON \
-DENABLE_BLOSC=ON \
Expand Down Expand Up @@ -138,6 +138,9 @@ jobs:
cmake --build . --parallel 3 --config ${{ inputs.build_mode }}
cmake --install . --config ${{ inputs.build_mode }}

# TODO: Blosc2 testing is currently disabled when it is fetched from
# the development git branch due to upstream changes which need fixes
# in the hdf5_plugins logic.
# NOTE: HDF_ENABLE_BLOSC_ZLIB_SUPPORT is set to OFF because otherwise
# the hdf5_plugins Blosc build process will try to build its own zlib
# instead of allowing blosc to use its internal sources that are patched
Expand All @@ -154,7 +157,7 @@ jobs:
-DH5PL_BUILD_EXAMPLES=ON \
-DENABLE_BLOSC=ON \
-DHDF_ENABLE_BLOSC_ZLIB_SUPPORT=OFF \
-DENABLE_BLOSC2=ON \
-DENABLE_BLOSC2=OFF \
-DENABLE_BZIP2=ON \
-DENABLE_JPEG=ON \
-DENABLE_LZ4=ON \
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/main-fetchcontent-ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ permissions:

jobs:
# Test building filter libraries and hdf5_plugins project inline with CMake's
# FetchContent (git) functionality while building HDF5.
# FetchContent (tgz) functionality while building HDF5.
build_and_test_inline:
name: "Ubuntu GCC (hdf5_plugins built inline with HDF5)"
runs-on: ubuntu-latest
Expand Down Expand Up @@ -65,7 +65,7 @@ jobs:
-DHDF5_ENABLE_PLUGIN_SUPPORT=ON \
-DPLUGIN_USE_EXTERNAL=ON \
-DPLUGIN_USE_LOCALCONTENT=OFF \
-DH5PL_ALLOW_EXTERNAL_SUPPORT=GIT \
-DH5PL_ALLOW_EXTERNAL_SUPPORT=TGZ \
-DH5PL_BUILD_TESTING=ON \
-DH5PL_BUILD_EXAMPLES=ON \
-DENABLE_BLOSC=ON \
Expand Down Expand Up @@ -135,6 +135,9 @@ jobs:
cmake --build . --parallel 4 --config ${{ inputs.build_mode }}
cmake --install . --config ${{ inputs.build_mode }}

# TODO: Blosc2 testing is currently disabled when it is fetched from
# the development git branch due to upstream changes which need fixes
# in the hdf5_plugins logic.
- name: Build HDF5 plugins project
run: |
mkdir "${{ runner.workspace }}/build"
Expand All @@ -146,7 +149,7 @@ jobs:
-DH5PL_BUILD_TESTING=ON \
-DH5PL_BUILD_EXAMPLES=ON \
-DENABLE_BLOSC=ON \
-DENABLE_BLOSC2=ON \
-DENABLE_BLOSC2=OFF \
-DENABLE_BZIP2=ON \
-DENABLE_JPEG=ON \
-DENABLE_LZ4=ON \
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/main-fetchcontent-win.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ permissions:

jobs:
# Test building filter libraries and hdf5_plugins project inline with CMake's
# FetchContent (git) functionality while building HDF5.
# FetchContent (tgz) functionality while building HDF5.
build_and_test_inline:
name: "Windows MSVC (hdf5_plugins built inline with HDF5)"
runs-on: windows-latest
Expand Down Expand Up @@ -74,7 +74,7 @@ jobs:
-DHDF5_ENABLE_PLUGIN_SUPPORT=ON \
-DPLUGIN_USE_EXTERNAL=ON \
-DPLUGIN_USE_LOCALCONTENT=OFF \
-DH5PL_ALLOW_EXTERNAL_SUPPORT=GIT \
-DH5PL_ALLOW_EXTERNAL_SUPPORT=TGZ \
-DH5PL_BUILD_TESTING=ON \
-DH5PL_BUILD_EXAMPLES=ON \
-DENABLE_BLOSC=ON \
Expand Down Expand Up @@ -151,6 +151,9 @@ jobs:
cmake --build . --parallel 4 --config ${{ inputs.build_mode }}
cmake --install . --config ${{ inputs.build_mode }}

# TODO: Blosc2 testing is currently disabled when it is fetched from
# the development git branch due to upstream changes which need fixes
# in the hdf5_plugins logic.
- name: Build HDF5 plugins project
shell: bash
run: |
Expand All @@ -163,7 +166,7 @@ jobs:
-DH5PL_BUILD_TESTING=ON \
-DH5PL_BUILD_EXAMPLES=ON \
-DENABLE_BLOSC=ON \
-DENABLE_BLOSC2=ON \
-DENABLE_BLOSC2=OFF \
-DENABLE_BZIP2=ON \
-DENABLE_JPEG=ON \
-DENABLE_LZ4=ON \
Expand Down
Loading