Skip to content

Test BitGroom/BitRound h5repack with float data#245

Open
ajelenak wants to merge 2 commits intomasterfrom
issue-240
Open

Test BitGroom/BitRound h5repack with float data#245
ajelenak wants to merge 2 commits intomasterfrom
issue-240

Conversation

@ajelenak
Copy link
Copy Markdown
Contributor

@ajelenak ajelenak commented May 1, 2026

Both plugins' ` callbacks remove themselves from the pipeline on
non-float datasets, so the previous shared h5repack_layout.h5 input (integer
data) caused the tests to silently apply nothing once the plugin path was
fixed in #238.

Each plugin now ships a small h5repack_floats helper that
generates a chunked dataset of non-integer floats, and two h5dump checks
on the post-repack output assert that the filter ID stays in the pipeline
(via the -pH command options) and that the dumped values match the captured
quantized output (via a .ddl output).

Closes #240.

Copy link
Copy Markdown
Contributor

@brtnfld brtnfld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add_executable placed outside if (H5PL_BUILD_TESTING) — minor

In both BITGROOM/example/CMakeLists.txt and BITROUND/example/CMakeLists.txt, the h5repack_floats_* executables are compiled unconditionally, even when H5PL_BUILD_TESTING=OFF. Unlike the example programs that live before the if (H5PL_BUILD_TESTING) block (which are independently useful), these generators serve no purpose outside of testing. Consider guarding them:


if (H5PL_BUILD_TESTING)
  add_executable (h5repack_floats_bitgroom ${PROJECT_SOURCE_DIR}/h5repack_floats.c)
  ...
endif ()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Bitgroom and Bitround h5repack testing

3 participants