Create stat card component - #26852
Merged
Merged
Conversation
kroepke
self-requested a review
August 3, 2026 09:51
kroepke
requested changes
Aug 4, 2026
kroepke
left a comment
kroepke
left a comment
Member
There was a problem hiding this comment.
Overall looks good to me, apart from the one behavior change when a card is not a link.
| ({ theme, $variant }) => css` | ||
| position: relative; | ||
| text-align: center; |
Member
There was a problem hiding this comment.
This text-align made a non-button statcard work, so I believe we need to add it back. Below "Sources" is not a button, because there's no single page we could link to.
Right now text-align: center comes from the Button, but I think we should add it to all StatCard instances. It probably shouldn't live in the AccessibleCard in general.
Contributor
Author
There was a problem hiding this comment.
Nice catch. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR creates stat card component and replace it usage in collectors
The visual difference is that now the label is on the top of the number. That was done to fit sub value option as well
Motivation and Context
fix: #26850
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
/nocl
/jpd https://github.com/Graylog2/graylog-plugin-enterprise/pull/15070