Bumping non-snapshot packages to latest stable versions#2066
Bumping non-snapshot packages to latest stable versions#2066loosebazooka merged 1 commit intomainfrom
Conversation
Signed-off-by: Distroless Bot <distroless-bot@google.com>
|
🌳 🔧 Config Check This pull request has not modified the root BUILD |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Temurin JDK and JRE versions to 17.0.19 and 25.0.3, along with their corresponding test data and lock files for Debian 13. Feedback highlights missing closing double quotes in the expected error strings for Java 17 tests, which causes inconsistency with other test files. Furthermore, the version bumps in the Adoptium lock file are inconsistent across architectures, potentially leading to environment drift on non-x86 platforms.
| command: "/usr/lib/jvm/temurin-17-jre-amd64/bin/java" | ||
| args: ["-version"] | ||
| expectedError: ['openjdk version "17.0.18'] | ||
| expectedError: ['openjdk version "17.0.19'] |
There was a problem hiding this comment.
The expected error string for the Java version is missing a closing double quote inside the list. This is inconsistent with other test data files in this PR (e.g., java17_debug_debian13.yaml or java25_debian13.yaml) and may lead to less precise matching.
expectedError: ['openjdk version "17.0.19"']| command: "/usr/bin/java" | ||
| args: ["-version"] | ||
| expectedError: ['openjdk version "17.0.18'] | ||
| expectedError: ['openjdk version "17.0.19'] |
There was a problem hiding this comment.
The expected error string for the Java version is missing a closing double quote inside the list. This is inconsistent with other test data files in this PR.
expectedError: ['openjdk version "17.0.19"']| "arch": "amd64", | ||
| "dependencies": [], | ||
| "key": "temurin-17-jre_17.0.18.0.0-p-8-1_amd64", | ||
| "key": "temurin-17-jre_17.0.19.0.0-p-10-0_amd64", |
There was a problem hiding this comment.
The version bump for Temurin packages is inconsistent across architectures. For instance, temurin-17 was updated to 17.0.19.0.0+10-0 for amd64, but remains at 17.0.18.0.0+8-0 for arm64, ppc64el, riscv64, and s390x. Similarly, temurin-25 was updated for amd64 and s390x, but not for other architectures. This inconsistency can lead to environment drift and potential CI failures on non-x86 platforms. Please ensure all architectures are updated to the latest stable versions if available.
|
🌳 🔄 Image Check This pull request has modified the following images: //java:java17_root_amd64_debian13
//java:java17_root_amd64_debian13
//java:java17_debug_root_amd64_debian13
//java:java17_nonroot_amd64_debian13
//java:java17_debug_nonroot_amd64_debian13
//java:java17_nonroot_amd64_debian13
//java:java17_debug_nonroot_amd64_debian13
//java:java17_debug_root_amd64_debian13
//java:java25_debug_nonroot_amd64_debian13
//java:java25_debug_nonroot_amd64_debian13
//java:java25_nonroot_amd64_debian13
//java:java25_debug_root_amd64_debian13
//java:java25_root_amd64_debian13
//java:java25_debug_root_amd64_debian13
//java:java25_root_amd64_debian13
//java:java25_debug_nonroot_s390x_debian13
//java:java25_nonroot_amd64_debian13
//java:java25_debug_nonroot_s390x_debian13
//java:java25_root_s390x_debian13
//java:java25_nonroot_s390x_debian13
//java:java25_nonroot_s390x_debian13
//java:java25_debug_root_s390x_debian13
//java:java25_root_s390x_debian13
//java:java25_debug_root_s390x_debian13You can check the details in the report here |
2 participants
Bumping non-snapshot packages to latest stable version