feat(storagecontrol): add delete folder recursive sample#14382
Draft
nidhiii-27 wants to merge 2 commits into
Draft
feat(storagecontrol): add delete folder recursive sample#14382nidhiii-27 wants to merge 2 commits into
nidhiii-27 wants to merge 2 commits into
Conversation
Adds a Python code sample demonstrating hierarchical namespace recursive folder delete. Fixes: b/530058898 [Generated-by: AI]
product-auto-label
Bot
added
the
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new script delete_folder_recursive.py to recursively delete folders in Google Cloud Storage using the Storage Control API, along with corresponding integration tests in snippets_test.py. Feedback is provided regarding an incorrect type hint for the capsys fixture in the test file, which should be typed as pytest.CaptureFixture[str] instead of pytest.LogCaptureFixture.
|
|
||
|
|
||
| def test_delete_folder_recursive( | ||
| capsys: pytest.LogCaptureFixture, hns_enabled_bucket: storage.Bucket, uuid_name: str |
Contributor
There was a problem hiding this comment.
The capsys fixture in pytest is of type pytest.CaptureFixture[str], not pytest.LogCaptureFixture (which is used for caplog). Using the correct type hint avoids static analysis/type-checking warnings.
Suggested change
| capsys: pytest.LogCaptureFixture, hns_enabled_bucket: storage.Bucket, uuid_name: str | |
| capsys: pytest.CaptureFixture[str], hns_enabled_bucket: storage.Bucket, uuid_name: str |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Python code sample demonstrating hierarchical namespace recursive folder delete.
Fixes: b/530058898