feat(cloudkms): add samples for CryptoKey/CryptoKeyVersion deletion and get/lists RetiredResources

[yasharel]

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed Sample Guidelines from AUTHORING_GUIDE.MD
• README is updated to include all relevant information
• Tests pass: nox -s py-3.9 (see Test Environment Setup)
• Lint pass: nox -s lint (see Test Environment Setup)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

[snippet-bot]

Here is the summary of changes.

You are about to add 4 region tags.

• kms/snippets/delete_key.py:15, tag kms_delete_key
• kms/snippets/delete_key_version.py:15, tag kms_delete_key_version
• kms/snippets/get_retired_resource.py:15, tag kms_get_retired_resource
• kms/snippets/list_retired_resources.py:15, tag kms_list_retired_resources

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment

[gemini-code-assist]

Summary of Changes

Hello @yasharel, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Google Cloud Key Management Service (KMS) Python samples by introducing new functionalities for resource lifecycle management. It provides practical examples for deleting CryptoKeys and CryptoKeyVersions, and for querying retired resources. Additionally, the PR updates the core KMS client library dependency and includes a new test case to ensure the reliability of these new features.

Highlights

• New KMS Deletion Samples: Added new Python samples for deleting a Cloud KMS CryptoKey and a CryptoKeyVersion.
• New KMS Retired Resources Samples: Introduced new Python samples to get and list retired resources within Cloud KMS.
• Dependency Update: Updated the google-cloud-kms client library version to 3.11.0.
• New Test Coverage: Added a new integration test to validate the functionality of key deletion and the subsequent management of retired resources.

Changelog

• kms/snippets/delete_key.py
  • Added a new Python sample demonstrating how to delete a CryptoKey.
• kms/snippets/delete_key_version.py
  • Added a new Python sample demonstrating how to delete a CryptoKeyVersion.
• kms/snippets/get_retired_resource.py
  • Added a new Python sample demonstrating how to retrieve a specific retired resource.
• kms/snippets/list_retired_resources.py
  • Added a new Python sample demonstrating how to list all retired resources for a given location.
• kms/snippets/requirements.txt
  • Updated the google-cloud-kms library version from 3.2.1 to 3.11.0.
• kms/snippets/snippets_test.py
  • Imported the newly added delete_key, list_retired_resources, and get_retired_resource functions.
  • Added a new test function test_delete_key_and_retired_resources to verify the deletion of a key and the subsequent listing and retrieval of its retired resource entry.

Activity

• The author has confirmed adherence to the Sample Guidelines from AUTHORING_GUIDE.MD.
• The README has been updated to reflect the changes.
• All tests (nox -s py-3.9) have passed.
• Lint checks (nox -s lint) have passed.
• The author has requested the PR to be merged upon approval.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces new samples for Cloud KMS to demonstrate key deletion and handling of retired resources. The changes are generally good, but I've found a critical bug in the list_retired_resources sample that would cause it to always return an empty list. I've also pointed out several inconsistencies in the docstrings of the new samples that should be addressed for clarity and consistency. Lastly, the new delete_key_version sample is missing test coverage, which should be added.