Skip to content

chore(endpoints): update dependencies - #4457

Merged
angelcaamal merged 2 commits into
mainfrom
chore/update-endpoints-deps
Sep 10, 2026
Merged

chore(endpoints): update dependencies#4457
angelcaamal merged 2 commits into
mainfrom
chore/update-endpoints-deps

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes b/558840778
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples. labels Sep 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js engine requirement to >=20.0.0 and upgrades several dependencies across the getting-started and getting-started-grpc packages, including @grpc/grpc-js, @grpc/proto-loader, chai, express, and c8. However, upgrading chai to ^6.0.0 will break the tests because Chai v5+ is ESM-only, which is incompatible with this CommonJS project. It is recommended to revert chai to ^4.5.0 to avoid runtime errors.

Comment thread endpoints/getting-started-grpc/package.json
@angelcaamal
angelcaamal marked this pull request as ready for review September 8, 2026 22:30
@angelcaamal
angelcaamal requested review from a team as code owners September 8, 2026 22:30

@XrossFox XrossFox left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelcaamal
angelcaamal merged commit 668174d into main Sep 10, 2026
20 of 24 checks passed
@angelcaamal
angelcaamal deleted the chore/update-endpoints-deps branch September 10, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants