refactor(security-center): Rename securitycenter_list_findings_at_time region tag according new securitycenter_list_findings_within_time_range#4380
Open
Kef131 wants to merge 1 commit into
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the region tag comments in security-center/snippets/v1/listFindingsAtTime.js from securitycenter_list_findings_at_time to securitycenter_list_findings_within_time_range. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
b/517939862
Updated the region tag from
securitycenter_list_findings_at_timetosecuritycenter_list_findings_within_time_range. This is a requirement after migration of Java region tag from GoogleApis toJava-docs-samples, to be able to have ownership over the file and be able to address a decommission on Java.Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.