Skip to content

chore(grounding): remove decommissioned grounding samples#4376

Open
angelcaamal wants to merge 2 commits into
mainfrom
cleanup/remove-decommissioned-grounding-samples
Open

chore(grounding): remove decommissioned grounding samples#4376
angelcaamal wants to merge 2 commits into
mainfrom
cleanup/remove-decommissioned-grounding-samples

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Description

This PR removes the source code files and references for the following grounding code samples:

  • generativeaionvertexai_grounding_private_data_basic
  • generativeaionvertexai_grounding_public_data_basic

These samples are being deleted because their respective region tags are no longer used or required by Devsite. Cleaning them up helps reduce technical debt and avoids keeping unmaintained code in the repository.

Fixes Internal: b/533002326

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: genai labels Jul 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes two JavaScript sample files: one demonstrating content generation with Vertex AI Search grounding and another demonstrating content generation with Google Search grounding. I have no feedback to provide as there are no review comments.

@angelcaamal angelcaamal marked this pull request as ready for review July 9, 2026 17:01
@angelcaamal angelcaamal requested review from a team as code owners July 9, 2026 17:01

@XrossFox XrossFox left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: genai samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants